Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAF without flag -nocat4ad on MacOS #785

Open
mjlosch opened this issue Oct 11, 2023 · 0 comments
Open

TAF without flag -nocat4ad on MacOS #785

mjlosch opened this issue Oct 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@mjlosch
Copy link
Member

mjlosch commented Oct 11, 2023

Since PR #208 the flag -fixed is passed to TAF as part of TAF_EXTRA if -nocat4ad is specified, because "to get the *.flowdir processed correctly", because the flow-files with non-standard suffix .flow were treated as free-format by default.
This seems to be the problem here, too, as with MacOS the fixed format f77 files have the extension .for because the MacOS filesystem is case insensitive. All non-standard (.f) files with suffix .for are interpreted as free form leading to multiple errors.

I suggest to change

if test $CAT_SRC_FOR_TAF = 0 ; then TAF_EXTRA="${TAF_EXTRA} -fixed" ; fi

to

TAF_EXTRA="${TAF_EXTRA} -fixed"

for all cases. There are potential conflicts with #709, but that is not moving and we can sort that out later. In fact, #709 aims to combine fixed and free format file and since TAF-version 5.8.0 this is possible.

@mjlosch mjlosch added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant