Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept for Vasopressor Durations #111

Open
ajb5d opened this issue Feb 14, 2020 · 4 comments · May be fixed by #112
Open

Concept for Vasopressor Durations #111

ajb5d opened this issue Feb 14, 2020 · 4 comments · May be fixed by #112

Comments

@ajb5d
Copy link

ajb5d commented Feb 14, 2020

I'd like to contribute a materialized view for vasopressor durations (similar to the MIMIC tables). What is the preferred 'dialect' of SQL? BigQuery or Postgres? The syntax for casting is different between the two.

@tompollard
Copy link
Member

@ajb5d Thanks for the message, and good question! Either/both would be appreciated. We're using BigQuery a lot at the moment, especially at datathons, so a BigQuery version would definitely get some use.

We don't have a good system for managing different dialects of SQL, so we'd welcome your suggestions for this. With MIMIC we have ended up with two separate branches (google-cloud-views for BigQuery and master for Postgres), which isn't ideal.

@ajb5d
Copy link
Author

ajb5d commented Feb 15, 2020

Would it be reasonable make a directory for each dialect and keep them on the same branch?

Also, Are you opposed to a Postgres user-defined function? I'm having trouble finding an elegant way to cast a string to integer in a "safe" way.

@tompollard
Copy link
Member

Would it be reasonable make a directory for each dialect and keep them on the same branch?

I think this probably easier to navigate than separate branches, so sounds good to me.

Also, Are you opposed to a Postgres user-defined function? I'm having trouble finding an elegant way to cast a string to integer in a "safe" way.

Also sounds good to me!

@alistairewj
Copy link
Member

Sorry I haven't reviewed the PR yet, but hopefully I will find time to soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants