Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why hard-coded nameservers in tools/generator.py? #256

Open
hkelley opened this issue Nov 23, 2023 · 2 comments
Open

Why hard-coded nameservers in tools/generator.py? #256

hkelley opened this issue Nov 23, 2023 · 2 comments

Comments

@hkelley
Copy link

hkelley commented Nov 23, 2023

Outbound DNS is blocked in my environment. I can make the following changes locally, but a), I'm wondering what the original design objective was and b) how to make this change so that I'm not having to merge my local version with the latest git version every time I update.

resolver.nameservers = ["193.17.47.1", "185.43.135.1"] # CZ.NIC nameservers

def create_resolver() -> dns.resolver.Resolver:
    resolver = dns.resolver.Resolver() #(configure=False)
    resolver.timeout = 30
    resolver.lifetime = 30
    resolver.cache = dns.resolver.LRUCache()
    # resolver.nameservers = ["193.17.47.1", "185.43.135.1"]  # CZ.NIC nameservers
    return resolver

@adulau
Copy link
Member

adulau commented Nov 29, 2023

The original design was to have a consistent output for the generation. We had issue that due to geo-based DNS, we had different records sets coming from different public resolver. Maybe we should improve the script to make it configurable?

@hkelley
Copy link
Author

hkelley commented Nov 29, 2023

Yes, configurable (including the option to use the OS default resolver) would work for my scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants