Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguities regarding registry-key object #361

Open
3c7 opened this issue May 23, 2022 · 1 comment
Open

Ambiguities regarding registry-key object #361

3c7 opened this issue May 23, 2022 · 1 comment

Comments

@3c7
Copy link
Contributor

3c7 commented May 23, 2022

From the description of the registry-key object, it's not really clear, what kind of information to put where. The object states in the description, that it includes a key and a value, however, registry data needs three things:

  • key (the path, e.g. HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Run)
  • value (the value set, in this case, e.g. Windows Update Host)
  • data (the data itself, in this case a path to a file, e.g. C:\Users\User\AppData\Roaming\Microsoft\Update\Host.exe)

The object templates just defines key, data and a data-type (but not value). Probably the value is seen as part of the key here, but this is not mentioned in the description and in the typical microsoft terminology there is a difference between key and value.

As a JSON representation the difference would be like this:

MISP registry-key object

{
  "key": "data"
}

MS registry terminology

{
  "key": {
    "value": "data"
  }
}

Going to add a PR which changes the description of key, but wanted to create this issue for a potential discussion first.

@3c7
Copy link
Contributor Author

3c7 commented May 23, 2022

Or is name the equivalent to value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant