Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: custom logo upload does not work in .189. #9671

Open
1 task done
matthijsvp opened this issue Apr 11, 2024 · 6 comments
Open
1 task done

Bug: custom logo upload does not work in .189. #9671

matthijsvp opened this issue Apr 11, 2024 · 6 comments
Labels
needs triage This issue has been automatically labelled and needs further triage

Comments

@matthijsvp
Copy link

Actual behavior

Uploading a logo file to be used on the welcome page / site headers /etcetera works, but when trying to use the files the following error pops up:
image

There was reference to this in #9575, but I'm unsure if this merged fix is actually in the release already. In .189 the functionality still is broken.

Expected behavior

Logo upload through webinterface and configuring uploaded images for use should work as intended.

Steps to reproduce

  1. Upload a logo through the UI
  2. Try to use that logo on – for example – the welcome screen.

Version

2.4.189

Operating System

Ubuntu

Operating System version

22.04

PHP version

7.4.33

Browser

N/A

Browser version

No response

Relevant log output

No response

Extra attachments

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@matthijsvp matthijsvp added the needs triage This issue has been automatically labelled and needs further triage label Apr 11, 2024
@iglocska
Copy link
Member

I saw that @JakubOnderka pushed a fix for this already on develop, so it will be in the upcoming release, sorry for the inconvenience.

@matthijsvp
Copy link
Author

Gotcha, I saw that that PR was merged but wasn't sure in what version it should've been. Is there a way I could've known?

@Kagee
Copy link
Contributor

Kagee commented Apr 11, 2024

Whatever release was the first one after the PR was merged. A release is basicly just promoting everything in dev to 2.4.

@matthijsvp
Copy link
Author

Yeah but it was merged the 20th of February and there were some releases after that, so that's what made me question myself and resubmit.

@Kagee
Copy link
Contributor

Kagee commented Apr 11, 2024

Yes, this should be in .189. I can't see any relevant commits in current develop - 2.4...develop - @iglocska, are you sure this is not a new bug? 🤔

@iglocska
Copy link
Member

You are right, it was indeed a commit from february, not sure why I came across it again the other day. Will check it out what went wrong here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has been automatically labelled and needs further triage
Projects
None yet
Development

No branches or pull requests

3 participants