Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]No dataset.json after runing prepare_mic.py for Task012_LIDC #42

Open
hushunda opened this issue Nov 30, 2021 · 2 comments
Open

[Bug]No dataset.json after runing prepare_mic.py for Task012_LIDC #42

hushunda opened this issue Nov 30, 2021 · 2 comments
Labels
fix with next release Will be fixed after the next release

Comments

@hushunda
Copy link

Task: Task012_LIDC
When run nndet_prep, a bug has occurred—— Did not find dataset.json or dataset.yaml .
I think the dataset.yml should be generated when running prepare_mic.py. However, i do not find the generated code in the prepare_mic.py.

@hushunda
Copy link
Author

In addition, there are a lot of bugs when processing data of Task012_LIDC

@mibaumgartner
Copy link
Collaborator

Dear @hushunda ,

indeed, I forgot to add the dataset.yaml generation to the script (I generated it manually). I'll update the code to include the data, in the meantime you could generate it yourself, here is the info:

task: Task012_LIDC

name: LIDC
target_class:
test_labels: False # manually splitted test set

remove_classes: []
reorder_classes: {}
subtract_one_from_classes: False  # subtract one from all classes in mapping

labels:
    "0": "benign"
    "1": "malignant"

modalities:
    "0": "CT"

dim: 3

Most of the code is adapted from the original script of the medicaldetectiontoolkit (from here) and it worked on the data I received from my colleague. Can you specify in more detail which other bugs you mean?

I can see that the current preparation of the data is also somewhat cumbersome and I hope to provide an updated version with the help of newer tools like pylidc sometime in the future (PRs from the community are highly appreciated as well).

@mibaumgartner mibaumgartner added the fix with next release Will be fixed after the next release label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix with next release Will be fixed after the next release
Projects
None yet
Development

No branches or pull requests

2 participants