Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the relationship with github.com/decfpc/DelphiEncryptionCompendium? #8

Open
edwinyzh opened this issue Aug 24, 2020 · 4 comments
Labels

Comments

@edwinyzh
Copy link

Hello,
Thanks for the project!

Does this project has any ties with https://github.com/decfpc/DelphiEncryptionCompendium which has the exact same name?
Thanks!

@MHumm
Copy link
Owner

MHumm commented Aug 25, 2020

Thanks for pointing out this project. It seems like a copy of an older version which has been made FPC compatible and it has added a pure pascal implementation for all assembler only methods.
But:

  1. The DEC version you find here in this repository is except for the FPC support (which we simply didn't test) more advanced in my eyes.
  2. Why? It contains pure pascal implementations as well.
  3. It is cross platform compatible, all methods having AnsiString parameters are made unavailable on non supported platforms and TBytes based methods for nearly every purpose are implemented as well.
  4. It contains expanded KDF support. I found out meanwhile that Hagen's KDF2 is actually KDF1 so I renamed that but implemented KDF2 and KDF3 as well.
  5. The current version of the Whirlpool cipher has been added
  6. The structure of the library has been further modularized.
  7. The arcane test program has been replaced by DUnit tests and further tests have been written.
  8. Demo programs have been created. Some for consloe and some for FMX. Two of them are even published on Gogle Play: DEC Hash Demo and DEC Cipher Demo.
  9. XMLDOC code documentation has been added
  10. A PDF format manual has been added which has 39 pages as of today.

This one stems directly from the original. It is no fork! I took over development from Arvid Winkelsdorf even if technically this repository is still his. And I guess this one here is simply more advanced with a more modern code base.
If you like to contribute do so here ;-) Contributions are welcome, you'll find my e-mail address in NOTICE.TXT, it's the one with (main contact) added. Feel free to write me an e-mail.

@edwinyzh
Copy link
Author

@MHumm, Thanks for the detailed explanation, I understand it clearly now!

@MHumm MHumm added the question label Feb 12, 2021
@MHumm
Copy link
Owner

MHumm commented May 20, 2021

Looks like there could develop some cooperation of the author of decfpc and me. See other issue.

@MHumm
Copy link
Owner

MHumm commented Jun 10, 2021

There is some cooperation now, but decfpc has a bit different goals and requirements so both variants stay independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants