Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent Background #76

Open
joshmedeski opened this issue Apr 25, 2024 · 11 comments
Open

Transparent Background #76

joshmedeski opened this issue Apr 25, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@joshmedeski
Copy link

joshmedeski commented Apr 25, 2024

The part you want to Enhancement
Make superfile's background transparent.

Why it is necessary to enhancement
Better integrate with my terminal workflow.

Additional context
I saw a couple of theme examples had transparent backgrounds, but I'm unsure how to recreate it.

@joshmedeski joshmedeski added the enhancement New feature or request label Apr 25, 2024
@yorukot
Copy link
Owner

yorukot commented Apr 25, 2024

The transparent background is set by the user's terminal.

Most Linux desktop environments have software/extensions or just setting that can blur windows (such as Gnome Blur My Shell, etc.)

I'm not sure if it can be done on a Mac, but it can be done easily on most desktop environments on Linux.

@joshmedeski
Copy link
Author

Sorry if my wording was misleading. I want to disable the spf background. You can see the first image is how my terminal looks by default, then how spf looks (I want to remove the background color)

SCR-20240425-jdxu
SCR-20240425-jdyx

@yorukot
Copy link
Owner

yorukot commented Apr 25, 2024

It's not your English problem.
My English is awful:(

I think this is a good idea and I will add it!

@yorukot yorukot added the todo label Apr 25, 2024
@AnshumanNeon
Copy link
Contributor

currently you can just remove the whole background section. It will not apply any color.
but yh it's just undefined behaviour which we are misusing.
it'd be good to have an option for it.

@yorukot
Copy link
Owner

yorukot commented Apr 27, 2024

Should there be one more file to set related settings?
(related to theme but not color)

For example, Cursor is an arrow or option background highlight, as well as Border style, etc.

@AnshumanNeon
Copy link
Contributor

I don't think there is a need for it. But it will cause no harm. For long term, you should have one.

@yorukot
Copy link
Owner

yorukot commented Apr 28, 2024

image

Basically, this works really well, but since in the unfocused state the sidebar's border can be set to follow the background color or have its own color, this results in the sidebar's border not being able to determine if it should be eliminated or not.
(Other elements have some similar issues)

I'll ignore the question for now (it's not obvious in most cases) but this should be a issue in the future.

As for the location of the settings, I put them in config.toml (I think having one more file is a bit too redundant)

@yorukot
Copy link
Owner

yorukot commented Apr 28, 2024

Update in 4108d40
still have some issue need fix :(

Also update wiki https://github.com/MHNightCat/superfile/wiki/Style

@joshmedeski
Copy link
Author

Thanks, I'm looking forward to the next release.

@joshmedeski
Copy link
Author

Hey @MHNightCat a quick update:

  1. Looks like there is a typo on the config option (should be transparent_background with a d at the end)
  2. When I added this to my config it had no effect. I will play around with it more to figure out if it's a user error

@yorukot
Copy link
Owner

yorukot commented May 10, 2024

Thanks for the update!
Typos will be updated in the next version.

And I tried it on ubuntu and fedora and everything works fine.
I'm not sure why this setting doesn't work for you. Can you check the log file (~/.local/state/superfile/superfile.log)?

@yorukot yorukot removed the todo label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants