Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest AUR -bin doesn't provide the spf command #107

Closed
DMNinja opened this issue May 10, 2024 · 5 comments
Closed

The latest AUR -bin doesn't provide the spf command #107

DMNinja opened this issue May 10, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@DMNinja
Copy link

DMNinja commented May 10, 2024

Describe the bug
When installing the latest bin, it is expected that the installed package provides spf so superfile can run. This doesn't appear to be the case, and it must be invoked using /bin/superfile

To Reproduce
Steps to reproduce the behavior:

  1. Install the latest bin on your system
  2. Invoke spf to open superfile
  3. See error

Expected behavior
Superfile launches normally

System information

  • CPU: quad core AMD Ryzen 5 2400G with Radeon Vega Graphics (-MT MCP-)
  • speed/min/max: 1536/1600/3600 MHz
  • Kernel: 6.8.9-artix1-2 x86_64
  • Mem: 13.6 GiB
  • Shell: Zsh
  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Superfile Version: 1.1.2-1
@DMNinja DMNinja added the bug Something isn't working label May 10, 2024
@yorukot
Copy link
Owner

yorukot commented May 10, 2024

oh this is the first time I know someone has made AUR package...
But it works after I tested it. Can you send your error message?

@SuperBuker
Copy link

SuperBuker commented May 12, 2024

Hi, the error appears to be the binary filename set in the superfile-bin PKGBUILD.
Instead of installing the binay in /usr/bin/spf it's done in /usr/bin/superfile.

This said, there are two entries in AUR for superfile:

I'll drop a comment to the package maintainer and link this issue.

@zxp19821005
Copy link

@SuperBuker I've changed it to 'spf'.
But in my opinion, using superfile should be better to avoid conflicts with other system commands.
I think just changed CGO_ENABLED=0 go build -o ./bin/spf to ```CGO_ENABLED=0 go build -o ./bin/superfileinhttps://github.com/MHNightCat/superfile/blob/main/build.sh` will be OK.

@DMNinja
Copy link
Author

DMNinja commented May 13, 2024

@SuperBuker Thanks for explaining the PKGBUILD! I tried doing the same, but sadly my knowledge of reading code is severely underdeveloped.

Nevertheless, i made the wrong assumption that the AUR package was [maintained by MHNightCat] and for that i apologize. Although i do consider this topic resolved, I'm not certain if it's bad etiquette to close it down after the maintainer's comment, as i feel like it's a topic that could be discussed.

Either way, thank you all for adding to (and essentially resolving) the issue!

@SuperBuker
Copy link

Thanks @zxp19821005.

I perfectly understand your point of view about the possible conflicts, and as an AUR package maintainer you're fully entitled to make this kind of changes.

This said, the documentation of superfile only mentions the spf command and, just like @DMNinja, I got a bit confused when after installing superfile-bin from AUR "it didn't work". I checked the PKGBUILD, saw that the binary had been renamed and moved on.
Only when I realized the issue was affecting other users I decided to interviene and speed up the solution.

Finally, regarding the issue about possible binary name conflicts, I would suggest that if you have any concerns you open an issue in Github and discuss the matter with the developers. That way it can be handled in all the distros at once.

@DMNinja DMNinja closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants