Alter MDAnalsysi.base.AnanlysisBase

[PicoCentauri]

I know that @joaomcteixeira is not a fan of OOPing things but I will post this here anyway ;).
I thought about altering the base class with two new methods/attributes. A self.doc_dict attribute: a dictionary combining the docstring information and the callable signature. In principle, it is our

mdacli/src/mdacli/utils.py

Line 62 in 78fa3f2

def parse_callable_signature(callable_obj, storage_dict):

as a class method.

And a self.save_results() method based on our general approach could be added if no such a function exists.

If we dynamically alter the analysis class we are parsing this could help to improve our workflow and will help users/developers that try to use our python implementation.

[joaomcteixeira]

I am fan of OOP where OOP adds value 😆

I see, you want to polymorph the Analysis class possible save_results() with our own saving engine so that later in the CLI we only need to do .save_results() and avoid the try:catch block. Is that it? It can be a good application.

self.doc_dict is bad. Better have a self.doc and self.sig.

We need to do this only after #17 and #28 are merged, otherwise become too messy. 👍

[PicoCentauri]

Yes first of all to avoid the try/catch block. But this could also help us to remove the "reparsing" in

mdacli/src/mdacli/cli.py

Lines 277 to 278 in 6334ac4

	# Ugly that we have to parse again... but currently I have no better idea :(
	params = parse_docs(analysis_callable)[2] # Index [2] for paramaters

and helps solving #32.