Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe the document have some mistake #314

Open
davidgonghs opened this issue Apr 27, 2022 · 1 comment
Open

maybe the document have some mistake #314

davidgonghs opened this issue Apr 27, 2022 · 1 comment

Comments

@davidgonghs
Copy link

Good day!
I am David Gong, now a student at Malaysia First City University College.
In Assembly Language class, I use your MARIE.JS to test my program and write reports.
But now I have a question.
When I use Microstep to check my code, the RTL show AC ← AC - MBR.
image

Then ALU only A0 is activated, and I check GitHub Wiki Datapath Simulator https://github.com/MARIE-js/MARIE.js/wiki/Datapath-Simulator
the ALU opcode signals show subtraction opcode is 010, the active wires should be A1.
image

I'm wondering if I'm doing something wrong, or if it's just a documented bug.

Thank you!
Best regards!
David Gong

@auroranil
Copy link
Member

Hi David Gong,

Thank you for spotting this issue. According to commit 5d9ffeb, we made MARIE.js to be more consistent with the textbook, yet the changes were not reflected in the documentation.

I have updated the documentation to correct this mistake: https://github.com/MARIE-js/MARIE.js/wiki/Datapath-Simulator/_compare/0a1c55a129a400a7ac7c2033c1901f2a09273b84...a6649d328489a0529b491d26d02bd2cc2e904a45

Hopefully this resolve the issue.

Regards,
Saurabh Joshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants