Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rihanna gif for 504 Status code #58

Closed
wants to merge 5 commits into from

Conversation

mehtavishwa30
Copy link

Description of Changes

Relates to #43
#43

@M0nica M0nica linked an issue Oct 2, 2020 that may be closed by this pull request
@M0nica
Copy link
Owner

M0nica commented Oct 5, 2020

Thank you for this contribution, the GIF you added for 504 currently is the same as the one for 403: Forbidden. Can you please update your PR as per the README "The GIF should include Rihanna and not already be included on https://www.httriri.com/. In rare cases, a GIF that already exists in the HTTRIRI collection can be used for another status code but within the same set of proposed changes a new GIF should be chosen for the other status code to ensure there are no duplicate images and the overall size of the collection is growing".

Copy link
Owner

@M0nica M0nica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about the duplicate image.

@mehtavishwa30
Copy link
Author

Thanks for the note! I'll make the changes asap.

@M0nica
Copy link
Owner

M0nica commented Oct 19, 2020

Closing this as the GIF is a duplicate. If you'd like to add a new image for 504 status code, if it hasn't been added yet that then you may./

@M0nica M0nica closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rihanna GIF for Status Code 504
2 participants