Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ESP build test temporarily didn't work #423

Open
nicolas-rabault opened this issue Feb 9, 2023 · 2 comments · Fixed by #461
Open

[BUG] ESP build test temporarily didn't work #423

nicolas-rabault opened this issue Feb 9, 2023 · 2 comments · Fixed by #461
Assignees
@Simonbdy

Comments

@nicolas-rabault
Copy link
Member

Details

ESP build system recently change, with this change old build system also change using new tools. Those tool doesn't seems to work on windows.
We had to remove the build of ESP on GH just to bypass it.
We have to put it back when these tool will work.
nicolas-rabault added a commit that referenced this issue Feb 9, 2023
@nicolas-rabault
Temporarily remove the ESP build on GH, #423
f00e3e6
thobias90 pushed a commit to thobias90/luos_engine that referenced this issue Jan 4, 2024
Revert "Temporarily remove the ESP build on GH, Luos-io#423"
3de608a 
This reverts commit f00e3e6.
@thobias90
Copy link

Hello,

I'm working on it, looks like the cmake lists from ESP32 apps, that are not using arduino, were using wrong directory to append component.
Also, the cmake list from luos engine of ESP32 HAL were trying to add some src and inc files which name have changed or did not exists anymore.

This was referenced Jan 4, 2024
Draft
Merged
@nicolas-rabault
Copy link
Member Author

Thank you very much @thobias90 !
I'm currently working on a WebSocket network for Luos and was planning to put this issue back on top of my list to make it work on ESP!

@nicolas-rabault nicolas-rabault linked a pull request Jan 5, 2024 that will close this issue
Fix issue for ESP build test #461
Merged
7 tasks
@nicolas-rabault nicolas-rabault mentioned this issue Jan 5, 2024
Open
8 tasks
nicolas-rabault pushed a commit to thobias90/luos_engine that referenced this issue Jan 5, 2024
@nicolas-rabault
Revert "Temporarily remove the ESP build on GH, Luos-io#423"
a08e381 
This reverts commit f00e3e6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simonbdy Simonbdy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue for ESP build test thobias90/luos_engine
3 participants
@nicolas-rabault @Simonbdy @thobias90