Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pulling #271

Closed
wants to merge 1 commit into from
Closed

Feat/pulling #271

wants to merge 1 commit into from

Conversation

BiliouriV
Copy link
Contributor

PR Checklist

1- PR Comments

*If needed, to be filled by developer*



WARNING : Do not edit the checklist below.


2- Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (Non regression, new features & bug fixes)
  • [Code Quality] Remind to check if :
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

3- QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

nicolas-rabault
nicolas-rabault approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be to improved with #273

@nicolas-rabault nicolas-rabault mentioned this pull request Jul 4, 2022
Closed
@JeromeGalan JeromeGalan added this to the 2.6.0 milestone Jul 4, 2022
@JeromeGalan JeromeGalan changed the base branch from main to rc_2.5.2 July 6, 2022 13:14
@JeromeGalan JeromeGalan changed the base branch from rc_2.5.2 to rc_2.5.3 July 7, 2022 16:42
@nicolas-rabault nicolas-rabault linked an issue Jul 29, 2022 that may be closed by this pull request
[NEW FEATURE] [POLLING] Pull messages of specific topic #250
Open
@nicolas-rabault
Copy link
Member

This feature is not usefull for now.
This PR could be re-opened if needed

@BiliouriV BiliouriV deleted the feat/pulling branch August 1, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

@JeromeGalan JeromeGalan JeromeGalan left review comments

@Salem-Tho Salem-Tho Salem-Tho approved these changes

Assignees

@BiliouriV BiliouriV

Labels
None yet
Projects
Luos contribution project
Status: Todo
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

[NEW FEATURE] [POLLING] Pull messages of specific topic
4 participants
@BiliouriV @nicolas-rabault @Salem-Tho @JeromeGalan