Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend functionality of crop_edges #129

Open
jlaehne opened this issue Jun 15, 2022 · 3 comments · May be fixed by #177
Open

Extend functionality of crop_edges #129

jlaehne opened this issue Jun 15, 2022 · 3 comments · May be fixed by #177
Labels
type: feature request Asking for additional functionality

Comments

@jlaehne
Copy link
Contributor

jlaehne commented Jun 15, 2022

Describe the context

crop_edges is a wrapper function for inav that takes the parameter crop_px and removes as many pixels from all sides of a map.

Describe the functionality you would like to see.

To make this function more versatile, it would make sense to alternatively allow the following sets of parameters:

  • crop_x_px and crop_y_px to crop different amounts of pixels from the x and y directions
  • crop_left_px, crop_right_px, crop_top_px, crop_bottom_px to crop different amounts of pixels from all sides (check in matplotlib what order would be typically used for such a set of parameters corresponding to the edges).

Additional information

@jordiferrero , you originally implemented this function. Would this extension make sense to you? We have a student that could implement it.
@jlaehne jlaehne added the type: feature request Asking for additional functionality label Jun 15, 2022
@jlaehne jlaehne changed the title extend functionality of crop_edges Extend functionality of crop_edges Jun 15, 2022
@jlaehne jlaehne assigned jlaehne and unassigned jlaehne Jun 15, 2022
@jordiferrero
Copy link
Contributor

This makes sense.
I initially implemented this function because I always run this "simple" cropping during pre-processing.
It would be great for a student to do it. Just make sure the original functionality is still working (so when you only pass 1 parameter, it crops all sides equally).

@jlaehne
Copy link
Contributor Author

jlaehne commented Jun 22, 2022

Of course, one should be able to pass either of the three sets of parameters mentioned above.

@jordiferrero
Copy link
Contributor

Glad to hear a student is coming to help you with coding :-)

@jordiferrero jordiferrero mentioned this issue Sep 18, 2022
Closed
6 tasks
@jlaehne jlaehne linked a pull request Feb 16, 2023 that will close this issue
Crop edges update simplified #177
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request Asking for additional functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Crop edges update simplified jordiferrero/lumispy
2 participants
@jlaehne @jordiferrero