Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate axis conversion codes #152

Open
1 of 2 tasks
jlaehne opened this issue Sep 22, 2022 · 0 comments
Open
1 of 2 tasks

Consolidate axis conversion codes #152

jlaehne opened this issue Sep 22, 2022 · 0 comments

Comments

@jlaehne
Copy link
Contributor

jlaehne commented Sep 22, 2022

  • As pointed out in Fix bugs in to_raman_shift #140 (comment), there is quite some duplicate code in the if/else statements of the axis conversion codes that can be consolidated.

  • It would be desirable to allow any cross-conversions between wavelength, wavenumber and energy (documenting in the metadata the conversions to warn if multiple conversions are done on the same axis). To this end, it may be considered to move the main part of the code into a generalized conversion function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant