Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics run await.delay() too often #2665

Open
emmericp opened this issue May 13, 2024 · 1 comment
Open

Diagnostics run await.delay() too often #2665

emmericp opened this issue May 13, 2024 · 1 comment

Comments

@emmericp
Copy link
Contributor

#2664 got a 25% speed increase by disabling await.delay() for the non-interactive use case.

Many diagnostics call await.delay() for every single ast node they check, so running all diagnostics on a file will probably reschedule the thread more than once per node which is a significant overhead.

I guess fully removing it for the interactive use case isn't a great solution, but maybe there is some kind of middleground like only rescheduling only every n calls?

@emmericp
Copy link
Contributor Author

Note: this is likely not directly related to #2660, because that bug is about a slowdown that is way worse than only 25%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant