CONTRIBUTING.md

Hello! Thank you for choosing to help contribute to one of the SendGrid open source projects. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.

• CLAs and CCLAs
• Roadmap & Milestones
• Feature Request
• Submit a Bug Report
• Improvements to the Codebase
• Understanding the Code Base
• Testing
• Style Guidelines & Naming Conventions
• Creating a Pull Request

We use Milestones to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.

CLAs and CCLAs

Before you get started, SendGrid requires that a SendGrid Contributor License Agreement (CLA) or a SendGrid Company Contributor Licensing Agreement (CCLA) be filled out by every contributor to a SendGrid open source project.

Our goal with the CLA and CCLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way the CLA and CCLA encourage broad participation by our open source community and help us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.

SendGrid does not merge a pull request made against a SendGrid open source project until that pull request is associated with a signed CLA (or CCLA). Copies of the CLA and CCLA are available here.

You may submit your completed CLA or CCLA to SendGrid at dx@sendgrid.com. SendGrid will then confirm you are ready to begin making contributions.

There are a few ways to contribute, which we'll enumerate below:

Feature Request

If you'd like to make a feature request, please read this section.

The GitHub issue tracker is the preferred channel for library feature requests, but please respect the following restrictions:

• Please search for existing issues in order to ensure we don't have duplicate bugs/feature requests.
• Please be respectful and considerate of others when commenting on issues

Submit a Bug Report

Note: DO NOT include your credentials in ANY code examples, descriptions, or media you make public.

A software bug is a demonstrable issue in the code base. In order for us to diagnose the issue and respond as quickly as possible, please add as much detail as possible into your bug report.

Before you decide to create a new issue, please try the following:

1. Check the Github issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
2. Update to the latest version of this code and check if issue has already been fixed
3. Copy and fill in the Bug Report Template we have provided below

Please use our Bug Report Template

In order to make the process easier, we've included a sample bug report template (borrowed from Ghost). The template uses GitHub flavored markdown for formatting.

Improvements to the Codebase

We welcome direct contributions to the php-http-client code base. Thank you!

Development Environment

Install and Run Locally

Prerequisites

• PHP 5.6 or 7.0
• Composer

Initial setup:

git clone https://github.com/sendgrid/php-http-client.git
cd php-http-client

Environment Variables

First, get your free SendGrid account here.

Next, update your environment with your SENDGRID_API_KEY.

echo "export SENDGRID_API_KEY='YOUR_API_KEY'" > sendgrid.env
echo "sendgrid.env" >> .gitignore
source ./sendgrid.env

Execute:

See the [examples folder](https://github.com/sendgrid/php-http-client/tree/master/examples

Understanding the Code Base

/examples

Working examples that demonstrate usage.

/test/unit

Unit tests.

/lib/SendGrid/Client.php

An HTTP client with a fluent interface using method chaining and reflection. By returning self on __call and _(), we can dynamically build the URL using method chaining and __call allows us to dynamically receive the method calls to achieve reflection.

This allows for the following mapping from a URL to a method chain:

/api_client/{api_key_id}/version maps to client->api_client().->_($api_key_id)->version-><method>() where is a HTTP verb.

/lib/SendGrid/Config.php

Loads the environment variables.

Testing

All PRs require passing tests before the PR will be reviewed.

All test files are in the /test/unit directory.

For the purposes of contributing to this repo, please update the ClientTest.php file with unit tests as you modify the code.

phpunit --bootstrap test/unit/bootstrap.php --filter test* test/unit

Style Guidelines & Naming Conventions

Generally, we follow the style guidelines as suggested by the official language. However, we ask that you conform to the styles that already exist in the library. If you wish to deviate, please explain your reasoning.

• pear coding standards

Please run your code through:

• PHP Code Sniffer

Creating a Pull Request

1. Fork the project, clone your fork, and configure the remotes:

   # Clone your fork of the repo into the current directory
   git clone https://github.com/sendgrid/php-http-client
   # Navigate to the newly cloned directory
   cd sendgrid-python
   # Assign the original repo to a remote called "upstream"
   git remote add upstream https://github.com/sendgrid/php-http-client

2. If you cloned a while ago, get the latest changes from upstream:

   git checkout <dev-branch>
   git pull upstream <dev-branch>

3. Create a new topic branch (off the main project development branch) to contain your feature, change, or fix:

   git checkout -b <topic-branch-name>

4. Commit your changes in logical chunks. Please adhere to these git commit message guidelines or your code is unlikely be merged into the main project. Use Git's interactive rebase feature to tidy up your commits before making them public.

4a. Create tests.

4b. Create or update the example code that demonstrates the functionality of this change to the code.

5. Locally merge (or rebase) the upstream development branch into your topic branch:

   git pull [--rebase] upstream master

6. Push your topic branch up to your fork:

   git push origin <topic-branch-name>

7. Open a Pull Request with a clear title and description against the master branch. All tests must be passing before we will review the PR.

If you have any additional questions, please feel free to email us or create an issue in this repo.