New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

animated-properties/keyframe-base doesn't "s" but it is required in the schema #41

Open

Aidosmf opened this issue Jan 19, 2023 · 2 comments

Member

Aidosmf commented Jan 19, 2023

Please have a look: docs/schema/animated-properties/keyframe-base.json

Collaborator

mbasaglia commented Jan 19, 2023

The value of s depends on the type of keyframe, so it's defined in more specific schemas: https://github.com/LottieFiles/lottie-docs/blob/main/docs/schema/animated-properties/keyframe.json

So anything that should validate as keyframe-base needs to have that property

Member Author

Aidosmf commented Jan 19, 2023 •

edited

@mbasaglia but then you require "s" in the Keyframe? Seems like duplication or is it a common JSON-schema practice?

Or perhaps moving "s" into the "keyframe-base"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment