Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact detection enforcement in the v1 spikesorting pipeline #909

Open
samuelbray32 opened this issue Apr 2, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request spike sorting

Comments

@samuelbray32
Copy link
Collaborator

Working on helper functions for finding spikesorting merge ids based on a restriction and ran into a few questions:

  • The v1 spikesorting pipeline no longer enforces that users run artifact detection. This is divergent from the v0 pipeline where it was required (with the option of artifact parameters=None)

  • This means that the path for tracing an experimental interval like an epoch to the spikesorting is dependent on whether artifact detection is used.

  • If this is intended, I think the Tutorial notebook should emphasize usage of the tables clearly. From personal experience, the LFPV1 pipeline follows this unenforced artifact detection and makes it easy to miss the options.

Open to other suggestions on how to make this smoother as well

@edeno
Copy link
Collaborator

edeno commented Apr 2, 2024

@khl02007 thoughts on this?

@samuelbray32
Copy link
Collaborator Author

Adjacent to this, the example notebooks for clusterless and sorted decoding don't restrict to sorts from a given interval in making the groups, which is non-trivial if artifact was used.

Making a helper function to find sorts of interest to help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spike sorting
Projects
None yet
Development

No branches or pull requests

3 participants