Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names are confusing in the stats module #298

Open
Adoni5 opened this issue Oct 12, 2023 · 0 comments
Open

Names are confusing in the stats module #298

Adoni5 opened this issue Oct 12, 2023 · 0 comments
Labels
enhancement New feature or request idea Ideas for future work

Comments

@Adoni5
Copy link
Contributor

Adoni5 commented Oct 12, 2023

An idea but it would be nice to rename some of the counters and variables!

We have a lot of intermixing between actions and decisions going on.

Example:

    # Increment total actions count, Unblock, stop_receiving etc.
    self.actions[decision_name] += 1
    # increment count for this decision - single_off, single_on etc.
    self.decisions[kwargs.get("mode")] += 1

It would make more sense (IMO) to be updating self.decisions with decision_name and not mode.

Would be nice to work through these and standardise the names used in Counters

@Adoni5 Adoni5 added enhancement New feature or request idea Ideas for future work labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea Ideas for future work
Projects
Status: Backlog
Development

No branches or pull requests

1 participant