Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Orchard features testing should include Workflows and Audit Trail (OSOE-847) #363

Closed
Piedone opened this issue May 3, 2024 · 4 comments · Fixed by #365
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented May 3, 2024

Extend BasicOrchardFeaturesTestingUITestContextExtensions so it also tests Workflows and Audit Trail.

  • Do this similarly to how Media features are tested: a separate extension method just for Workflows, and one for Audit Trail (like TestMediaOperationsAsync()). Don't put all the code into the same class though.
  • No need to use page classes, just write the test also similar to TestMediaOperationsAsync().
  • For Workflows, test the following: Add workflow, add Event and Task, test that workflow runs. You can e.g. display a notification on login or a content item publish.
  • For Audit Trail, configure it to record events for a content type, test that content publishing for that type is correctly recorded.

Jira issue

@Piedone Piedone added the enhancement New feature or request label May 3, 2024
@github-actions github-actions bot changed the title Basic Orchard features testing should include Workflows and Audit Trail Basic Orchard features testing should include Workflows and Audit Trail (OSOE-847) May 3, 2024
@DemeSzabolcs DemeSzabolcs self-assigned this May 4, 2024
@DemeSzabolcs
Copy link
Member

DemeSzabolcs commented May 6, 2024

Extend BasicOrchardFeaturesTestingUITestContextExtensions

Don't put all the code into the same class though

@Piedone Do you mean to put these new methods in a new ...Extensions file?

@Piedone
Copy link
Member Author

Piedone commented May 6, 2024

It's up to you how to structure the code, just let's not make that class perpetually longer.

@DemeSzabolcs
Copy link
Member

What do you think, should we also test the creation itself of the workflow, so clicking trough each step, creating the event and the task, or creating it from a recipe is enough? Then testing the workflow of course.

Because I think clicking it together could be problematic during the part where you have to connect the event with the task:
image

@Piedone
Copy link
Member Author

Piedone commented May 8, 2024

We need to test that the workflow editor also works, yes, that's why I mentioned adding an Event and a Task. Drag and drop is possible in Selenium, so that step should not be an issue either. See e.g. https://www.browserstack.com/guide/drag-and-drop-in-selenium for inspiration (this is Java, but the API is the same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants