Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Failure Dump to Test Dump (OSOE-732) #323

Open
Piedone opened this issue Nov 16, 2023 · 0 comments
Open

Generalize Failure Dump to Test Dump (OSOE-732) #323

Piedone opened this issue Nov 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Piedone
Copy link
Member

Piedone commented Nov 16, 2023

Failure Dump is a useful feature to provide various output data in the form of files to the person inspecting tests. However, we sometimes want to provide such output even if the test passes. There are two cases already:

  • Accessibility reports, see AccessibilityCheckingConfiguration.CreateReportAlways. This has special treatment now in UITestExecutor.
  • Security scan reports, see SecurityScanningConfiguration.CreateReportAlways. This is not even working until this issue is completed.

So, rename Failure Dump (and everything related to it in the code, docs, and in LGHA) to Test Dump and change how it works:

  • Always generate it if UITestContext.FailureDumpContainer (which should be renamed) is non-empty.
  • Remove the special treatment of AccessibilityCheckingConfiguration.CreateReportAlways.
  • Make SecurityScanningConfiguration.CreateReportAlways public and remove the note from its docs about this issue.

Related: xunit/xunit#2457

Jira issue

@Piedone Piedone added the enhancement New feature or request label Nov 16, 2023
@github-actions github-actions bot changed the title Generalize Failure Dump to Test Dump Generalize Failure Dump to Test Dump (OSOE-732) Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant