New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add persistent others to dock #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual change here looks good to me, but I'd like it if you could avoid making unrelated formatting-only changes in the same PR
@Samasaur1 I didn't notice, it's my linter and auto format on save. I've reverted the formatting changes. |
@Samasaur1 I can't seem to understand why the tests fail. Are you able to help? |
Okay I manually checked the failing test on unstable, and it's only failing because of a missing newline. Seems like a false alarm; let me take a closer look and determine whether it's better to change the test or change the implementation back |
Ah, okay, you need another newline in the test file |
Thanks @Samasaur1, tests passed. |
Can you rebase the PR? |
0ae80d8
to
cb3d012
Compare
done @Enzime. |
cb3d012
to
9cdbf75
Compare
Can you rebase your PR on top of the latest master and squash your commits? Ideally your branch shouldn't contain the |
ae6dd46
to
e88183a
Compare
e88183a
to
457a5d9
Compare
should be ok now @Enzime |
The tests seem to be flaky, sometimes that check passes, others it doesn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution
This introduces a regression (warning) by using
|
Fixing in #950 |
Add persistent others to dock. Closes #927.