Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate DeezyMatch type error after release #106

Open
mcollardanuy opened this issue Apr 8, 2022 · 0 comments · Fixed by #202
Open

Investigate DeezyMatch type error after release #106

mcollardanuy opened this issue Apr 8, 2022 · 0 comments · Fixed by #202
Assignees
@mcollardanuy
Labels
bug Something isn't working candidate selection
Projects
Development

Comments

@mcollardanuy
Copy link
Collaborator

mcollardanuy commented Apr 8, 2022 •
edited

Check what's the error we're avoiding here:

https://github.com/Living-with-machines/toponym-resolution/blob/d4386ff6462d14140e742c7698f7fa4f3d800e57/utils/candidate_selection.py#L45-L67

See comment here.

To do after updating to DeezyMatch new release.

Also, check what's going on with the tmp folders.
@mcollardanuy mcollardanuy created this issue from a note in Development (To do) Apr 8, 2022
@mcollardanuy mcollardanuy self-assigned this Apr 8, 2022
@mcollardanuy mcollardanuy added bug Something isn't working depends on labels Apr 8, 2022
@mcollardanuy mcollardanuy mentioned this issue Apr 8, 2022
Merged
@mcollardanuy mcollardanuy moved this from To do to Backlog in Development Apr 8, 2022
@mcollardanuy mcollardanuy moved this from Backlog to In progress in Development Mar 13, 2023
@mcollardanuy mcollardanuy moved this from In progress to Backlog in Development Mar 13, 2023
@mcollardanuy mcollardanuy mentioned this issue Mar 22, 2023
Merged
@mcollardanuy mcollardanuy linked a pull request Mar 22, 2023 that will close this issue
Remove Deezy type exception #202
Merged
@mcollardanuy mcollardanuy moved this from Backlog to Under review in Development Mar 22, 2023
@mcollardanuy mcollardanuy moved this from Under review to Done in Development Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcollardanuy mcollardanuy

Labels
bug Something isn't working candidate selection
Projects
Development
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Deezy type exception Living-with-machines/T-Res
1 participant
@mcollardanuy