Update workshop notebooks from feedback #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 62.48% 62.35% -0.14%
==========================================
Files 39 39
Lines 6771 6766 -5
==========================================
- Hits 4231 4219 -12
- Misses 2540 2547 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmcdono2
approved these changes
Jun 3, 2024
|
sorry this took so long! I've approved your changes. I will make some new comments now in case this requires new updates before it gets merged. |
|
I've gone through the deep_solo, download, and the 2 data viz notebooks and added comments - not too much :) Will do parts 1 & 2 in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses some of the TODOs in #417 .
Fixes #420
Fixes #411
Fixes #408
Fixes #409
Fixes #406
Fixes #410
Describe your changes
Adds links to relevant documentation in the notebooks.
TODO::
Checklist before assigning a reviewer (update as needed)
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.