-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workshop notebooks from feedback #424
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 62.48% 62.35% -0.14%
==========================================
Files 39 39
Lines 6771 6766 -5
==========================================
- Hits 4231 4219 -12
- Misses 2540 2547 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sorry this took so long! I've approved your changes. I will make some new comments now in case this requires new updates before it gets merged. |
I've gone through the deep_solo, download, and the 2 data viz notebooks and added comments - not too much :) Will do parts 1 & 2 in the morning. |
Summary
This addresses some of the TODOs in #417 .
Fixes #420
Fixes #411
Fixes #408
Fixes #409
Fixes #406
Fixes #410
Describe your changes
Adds links to relevant documentation in the notebooks.
TODO::
Checklist before assigning a reviewer (update as needed)
Reviewer checklist
Please add anything you want reviewers to specifically focus/comment on.