Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev text spotting #435

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Dev text spotting #435

wants to merge 4 commits into from

Conversation

rwood-97
Copy link
Collaborator

@rwood-97 rwood-97 commented May 16, 2024

Summary

This PR adds new developments to the text spotting code:

  • Adds deduplicate methods for removing overlapping polygons within a patch and also between patches
  • Adds Runner base class to remove repeated code in the two different runners.

Fixes #404

Describe your changes

Describe changes/updates you have made to the code.

Checklist before assigning a reviewer (update as needed)

  • Self-review code
  • Ensure submission passes current tests
  • Add tests
  • Update relevant docs

Reviewer checklist

Please add anything you want reviewers to specifically focus/comment on.

  • Everything looks ok?

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 5.20231% with 164 lines in your changes are missing coverage. Please review.

Project coverage is 62.96%. Comparing base (282b873) to head (c238d9b).

Files Patch % Lines
mapreader/spot_text/runner_base.py 0.00% 156 Missing ⚠️
mapreader/spot_text/deepsolo_runner.py 0.00% 4 Missing ⚠️
mapreader/spot_text/dptext_detr_runner.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   62.69%   62.96%   +0.26%     
==========================================
  Files          40       41       +1     
  Lines        6782     6726      -56     
==========================================
- Hits         4252     4235      -17     
+ Misses       2530     2491      -39     
Flag Coverage Δ
unittests 62.96% <5.20%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add duplicate detection to text spotting code
2 participants