Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Less iframe nesting for embed mode in YT #422

Open
5 tasks done
ChrRubin opened this issue Jul 17, 2022 · 1 comment
Open
5 tasks done

[Feature]: Less iframe nesting for embed mode in YT #422

ChrRubin opened this issue Jul 17, 2022 · 1 comment

Comments

@ChrRubin
Copy link
Member

Checklist

  • This is a suggestion for LiveTL, not Hyperchat. I will go to the Hyperchat repo to suggest a feature for Hyperchat.
  • This is a suggestion for the LiveTL web extension, not LiveTL iOS or LiveTL Android. I will go to the iOS or Android repo to suggest features for those platforms.
  • I have checked for a duplicate or similar feature request/issue. I made sure to check closed issues as well.
  • I am not reporting a bug. If I am, I will use the bug report issue template.
  • By submitting this issue, you agree to follow our Code of Conduct

Is your feature request related to a problem? Please describe.

Currently Embed Mode on YT nests the entire watch page into the YTC iframe. This causes problems such as resizing the window kills LTL, since YTC just refreshes itself for some reason, and just overall jank.

Describe the solution you'd like

Inject the resize bar and popup page at the bottom of the YTC frame. We already have it working on Twitch, just have to move it to YTC.

After we implement this we can probably simplify the logic of the watch page too, since it no longer needs a "only chat and filter output" mode.

Describe alternatives you've considered

No response

Anything else?

No response

@ChrRubin
Copy link
Member Author

Nvm YT is dumb and reloads the entire frame so even if we don't nest the entire watch page LTL on Embed Mode will still get killed on window resize.

Only way to solve that would be to inject LTL outside of the YTC frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant