Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user before updating extension #425

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

r2dev2
Copy link
Member

@r2dev2 r2dev2 commented Jul 24, 2022

This prompts the user before allowing the extension to update. I currently have no way of testing with actually updating the extension and have been calling my update callback manually.

Fixes #419

@r2dev2
Copy link
Member Author

r2dev2 commented Jul 24, 2022

update popup

Let me know if anyone knows how to simulate updating the extension's version. I have tried using the reload button in about:debugging but that just closes the extension even though I am listening to onUpdateAvailable. Updating the package.json did not work either.

@r2dev2 r2dev2 requested review from KentoNishi and ChrRubin and removed request for KentoNishi July 24, 2022 07:05
@ChrRubin
Copy link
Member

I don't have a PC available to check, but I think the onMount call is erroring, which is why e2e is failing.

runtime.onUpdateAvailable isn't available for content scripts so I would guess it isn't available for pages too.

@r2dev2
Copy link
Member Author

r2dev2 commented Jul 25, 2022

I don't have a PC available to check, but I think the onMount call is erroring, which is why e2e is failing.

runtime.onUpdateAvailable isn't available for content scripts so I would guess it isn't available for pages too.

Where does it say that onUpdateAvailable isn't there for content scripts? I am able to console.log chrome.runtime.onUpdateAvailable from the page.

@ChrRubin
Copy link
Member

ChrRubin commented Jul 25, 2022

https://developer.chrome.com/docs/extensions/mv3/content_scripts/

Who knows if it's different for extension pages, usually it isn't ¯\_(ツ)_/¯

@r2dev2
Copy link
Member Author

r2dev2 commented Aug 13, 2022

Moving to draft as this is low priority and high effort so we can figure it out later, perhaps during the mv3 rework.

@r2dev2 r2dev2 marked this pull request as draft August 13, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Keep or Re-Open Existing LiveTL Tabs On Update Push
2 participants