Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venus Forces Non-Secure Protocol on Hostname #291

Open
derekbrown opened this issue Oct 1, 2013 · 4 comments
Open

Venus Forces Non-Secure Protocol on Hostname #291

derekbrown opened this issue Oct 1, 2013 · 4 comments

Comments

@derekbrown
Copy link

When specifying a hostname in command line via the --hostname flag, Venus automatically prepends "http://". For my purposes, I think this should only be done if the string passed to --hostname does not begin with a protocol string. As a use case, I have tests that are hosted on a secure host that I cannot run remotely.

-Derek

@sethmcl
Copy link
Contributor

sethmcl commented Oct 1, 2013

Hey Derek, could you checkout out #292. Is this what you had in mind? Trying to fully understand your scenario.

@derekbrown
Copy link
Author

That is exactly what I had in mind for what I'm doing. I'm just trying to be a bit more forward thinking in terms of other use cases. What if the tests are on an FTP server? Or to be run over SSH? Etc. I think for sustainability, Venus should run a RegEx against the hostname string. If it begins with a protocol ("____://"), then don't add one. If it doesn't, default to http:// ?

The --secure option works perfect for me, though.

@sethmcl
Copy link
Contributor

sethmcl commented Oct 1, 2013

Not sure why the tests would be on some other server? They are served by venus so they are on the Venus server, which is http:// by default.

@derekbrown
Copy link
Author

Yeah. In this case, I had a request where someone wants to automate tests within a Gitli-hosted repository without pulling it down. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants