Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write out quaternion components to a fixed precision in write_material #10

Open
aplowman opened this issue Apr 20, 2021 · 1 comment
Open

Write out quaternion components to a fixed precision in write_material #10

aplowman opened this issue Apr 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@aplowman
Copy link
Contributor

DAMASK seems to dislike variable numbers of digits.

damask-parse/damask_parse/writers.py

Line 325 in 2a08ffd

yaml.dump(mat_dat, mat_path)

Stack Overflow solution
@aplowman aplowman added the bug Something isn't working label Apr 20, 2021
@aplowman
Copy link
Contributor Author

It seems instead that DAMASK has a very stringent normalisation criterion, and we should try casting quaternions to np.longdouble, then normalise, then write out to as many digits as np.longdouble supports on a given machine.

@Gbowker Gbowker linked a pull request May 21, 2021 that will close this issue
Change/machine-precision_quats #8
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change/machine-precision_quats LightForm-group/damask-parse
1 participant
@aplowman