New modify_volume_element methods #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gbowker
commented
May 20, 2021
Gbowker
commented
- Added task schema methods ''new_orientations" and "geometry" In task "modify_volume_element" to support feat/multipass in matflow-damask.
- Added task schema methods ''new_orientations" and "geometry" In task "modify_volume_element" to support feat/multipass in matflow-damask.
Gbowker
added
enhancement
|
This is a little confusing for me, I think you have rebased your changes on to the end of the features I've been working on. All your changes look fine but this is blocked until the changes in matflow-damask and damask-parse are all in a branch together. |
|
Closing this pull request as it is rebased to the end of changes made by @mikesmic . I'm going instead to commit my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.