Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash scrolling feed #45

Open
Efreak opened this issue Jul 5, 2022 · 2 comments
Open

Crash scrolling feed #45

Efreak opened this issue Jul 5, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@Efreak
Copy link

Efreak commented Jul 5, 2022

I get this crash while scrolling my feed in the app, took quite a while to track it down. Going by the error, I'm guessing it's an issue with a release. I'm trying now to figure out which release it is.

07-05 00:42:26.932 21654 21654 E AndroidRuntime: FATAL EXCEPTION: main�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: Process: com.fastaccess.github.revival, PID: 21654�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: java.lang.NullPointerException: release!!.name must not be null�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.adapter.viewholder.FeedsViewHolder.appendReleaseEvent(FeedsViewHolder.kt:168)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.adapter.viewholder.FeedsViewHolder.bind(FeedsViewHolder.kt:101)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.adapter.FeedsAdapter.onBindView(FeedsAdapter.kt:23)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.adapter.FeedsAdapter.onBindView(FeedsAdapter.kt:12)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.base.adapter.BaseRecyclerAdapter.onBindViewHolder(BaseRecyclerAdapter.kt:113)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.fastaccess.ui.base.adapter.BaseRecyclerAdapter.onBindViewHolder(BaseRecyclerAdapter.kt:18)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7254)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7337)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6194)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6460)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at androidx.recyclerview.widget.GapWorker.run(GapWorker.java:399)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:938)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:226)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:313)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8663)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)�[0m
07-05 00:42:26.932 21654 21654 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)�[0m
@LightDestory
Copy link
Owner

It seems a release uses a non ASCII character, maybe an emoji?

Why should anyone include an emoji on the release name?

To fix it we should sanitize the release name before updating the view

@LightDestory LightDestory added the bug Something isn't working label Jul 5, 2022
@LightDestory LightDestory added this to the 4.7.8 goals milestone Jul 5, 2022
@Iamlooker
Copy link

It seems a release uses a non ASCII character, maybe an emoji?

Why should anyone include an emoji on the release name?

To fix it we should sanitize the release name before updating the view

I myself use emojis in release name, its fun.

Instead of sanitizing I would suggest you simple add support with the help of emoji library with is an extension library for app-compat library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants