Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CS CLAIM doesn't properly update last modified on CS FLAGS #11

Closed
stwalkerster opened this issue Dec 15, 2022 · 0 comments · Fixed by #12
Closed

CS CLAIM doesn't properly update last modified on CS FLAGS #11

stwalkerster opened this issue Dec 15, 2022 · 0 comments · Fixed by #12

Comments

@stwalkerster
Copy link
Member

When a group contact has limited flags in a channel (for example, +Aiotv) and that group contact runs /CS CLAIM to gain founder privileges on the channel, the output from CS FLAGS reports the updated flags, but the last modified timestamp and account name do not get updated.

Reproduction steps

  1. Register a project with namespace/contact and openreg set
/msg projectserv register helpmebot
/msg projectserv channel helpmebot add #helpmebot
/msg projectserv contact helpmebot add stwalkerster
/msg projectserv set helpmebot openreg on
/msg projectserv info helpmebot
22:18:42 -ProjectServ- Information on helpmebot:
22:18:42 -ProjectServ- Registered on Dec 15 22:17:15 2022 +0000 by stwalkerster!~user@172.25.1.1{earth.localnet}
22:18:42 -ProjectServ- Channel namespaces: #helpmebot
22:18:42 -ProjectServ- Cloak namespaces: (none)
22:18:42 -ProjectServ- Group contacts (private): stwalkerster
22:18:42 -ProjectServ- Anyone may register channels in the project namespace
22:18:42 -ProjectServ- *** End of Info ***
  1. Register a channel as a non-contact user
/cs register #helpmebot
22:19:12 -ChanServ- #helpmebot is now registered to dng.
22:19:12 -ChanServ- The #helpmebot namespace is managed by the helpmebot project.
/cs flags #helpmebot
22:19:22 -ChanServ- Entry    Nickname/Host          Flags
22:19:22 -ChanServ- ----------------------------------------------------------------
22:19:22 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 3s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:19:22 -ChanServ- ----------------------------------------------------------------
22:19:22 -ChanServ- End of #helpmebot FLAGS listing.
  1. As contact user, claim channel. Observe flag setter is correctly set to stwalkerster.
/cs claim #helpmebot
22:24:55 -ChanServ- Full access to #helpmebot has been granted to stwalkerster on behalf of the helpmebot project.
/cs flags #helpmebot
22:25:21 -ChanServ- Entry    Nickname/Host          Flags
22:25:21 -ChanServ- ----------------------------------------------------------------
22:25:21 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 6m 6s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:25:21 -ChanServ- 2        stwalkerster           +AFORefiorstv        (FOUNDER) [modified 23s ago, on Dec 15 22:24:53 2022 +0000, by stwalkerster]
22:25:21 -ChanServ- ----------------------------------------------------------------
22:25:21 -ChanServ- End of #helpmebot FLAGS listing.
  1. Reduce contact's access to channel as non-contact user. Observe last modification user is non-contact user dng.
/cs flags #helpmebot stwalkerster -*+Aio 
Flags -FORefrstv were set on stwalkerster in #helpmebot.
/cs flags #helpmebot
22:26:48 -ChanServ- Entry    Nickname/Host          Flags
22:26:48 -ChanServ- ----------------------------------------------------------------
22:26:48 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 7m 25s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:26:48 -ChanServ- 2        stwalkerster           +Aio                 [modified 12s ago, on Dec 15 22:26:23 2022 +0000, by dng]
22:26:48 -ChanServ- ----------------------------------------------------------------
22:26:48 -ChanServ- End of #helpmebot FLAGS listing.
  1. Reclaim channel as contact
/cs claim #helpmebot
22:27:35 -ChanServ- Full access to #helpmebot has been granted to stwalkerster on behalf of the helpmebot project.
/cs flags #helpmebot
22:27:37 -ChanServ- Entry    Nickname/Host          Flags
22:27:37 -ChanServ- ----------------------------------------------------------------
22:27:37 -ChanServ- 1        dng                    +AFORefiorstv        (FOUNDER) [modified 8m 26s ago, on Dec 15 22:19:10 2022 +0000, by dng]
22:27:37 -ChanServ- 2        stwalkerster           +AFORefiorstv        (FOUNDER) [modified 1m 13s ago, on Dec 15 22:26:23 2022 +0000, by dng]
22:27:37 -ChanServ- ----------------------------------------------------------------
22:27:37 -ChanServ- End of #helpmebot FLAGS listing.

Observe the last modified date and user is still the non-contact dng user, implying that dng granted the founder flags.

I expect that the last modified timestamp and user would be updated to match the acting user - in this case the group contact.

This only occurs if the group contact already has some level of access to a channel. If the group contact does not appear in the channel's ACL prior to the /CS CLAIM, then the last modified time/user are correctly set.
stwalkerster added a commit to stwalkerster/atheme-extra that referenced this issue Jan 25, 2023
@stwalkerster
Set last modified date+user on CS CLAIM
fbf3a37 
Currently CS CLAIM doesn't update the last modified by date and user
when a CS CLAIM is done if an ACL entry for the user already exists.
This change makes sure that those fields are overwritten where needed.

Resolves: Libera-Chat#11
stwalkerster added a commit to stwalkerster/atheme-extra that referenced this issue Jan 25, 2023
@stwalkerster
Set last modified date+user on CS CLAIM
59fd2b3 
Currently CS CLAIM doesn't update the last modified by date and user
when a CS CLAIM is done if an ACL entry for the user already exists.
This change makes sure that those fields are overwritten where needed.

Resolves: Libera-Chat#11
@stwalkerster stwalkerster mentioned this issue Jan 25, 2023
Merged
stwalkerster added a commit to stwalkerster/atheme-extra that referenced this issue Feb 20, 2024
@stwalkerster
Set last modified date+user on CS CLAIM
ea1cef2 
Currently CS CLAIM doesn't update the last modified by date and user
when a CS CLAIM is done if an ACL entry for the user already exists.
This change makes sure that those fields are overwritten where needed.

Resolves: Libera-Chat#11
stwalkerster added a commit to stwalkerster/atheme-extra that referenced this issue Feb 20, 2024
@stwalkerster
Set last modified date+user on CS CLAIM
e28f071 
Currently CS CLAIM doesn't update the last modified by date and user
when a CS CLAIM is done if an ACL entry for the user already exists.
This change makes sure that those fields are overwritten where needed.

Resolves: Libera-Chat#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set last modified date+user on CS CLAIM stwalkerster/atheme-extra
1 participant
@stwalkerster