Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLBuilder Options #657

Open
scriptsure opened this issue Nov 27, 2022 · 0 comments
Open

XMLBuilder Options #657

scriptsure opened this issue Nov 27, 2022 · 0 comments

Comments

@scriptsure
Copy link

Some updates to the XMLBuilder no longer allow for spaces in the name of the node.

BUT thankfully they did add an option to perform noValidation on the name.

The issue is that xml2js doesnt allow me to pass the options through to XMLBuilder. Would you object to changing the following code?

rootElement = builder.create(rootName, this.options.xmldec, this.options.doctype, {
    headless: this.options.headless,
    allowSurrogateChars: this.options.allowSurrogateChars
  });

TO THIS:

rootElement = builder.create(rootName, this.options.xmldec, this.options.doctype, {
    ...this.options
  });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant