Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to choose default comment sort in user settings #4128

Open
4 tasks done
iByteABit256 opened this issue Nov 3, 2023 · 4 comments · May be fixed by #4469
Open
4 tasks done

Ability to choose default comment sort in user settings #4128

iByteABit256 opened this issue Nov 3, 2023 · 4 comments · May be fixed by #4469
Labels
area: sorting enhancement New feature or request

Comments

@iByteABit256
Copy link
Contributor

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Is your proposal related to a problem?

I would like to be able to select a default comment sort just like with post sorting

Describe the solution you'd like.

A new field in user settings for comment sort type, just like with the default post sort.

Describe alternatives you've considered.

Related to #3796, but I think the user should be able to have this option too

Additional context

No response
@iByteABit256 iByteABit256 added the enhancement New feature or request label Nov 3, 2023
@Die4Ever
Copy link

On Reddit, you can set the sorting order for comments on a per post basis. So sometimes the comments inside a megathread would be set to sorted by new by default. So I guess the post should be able to override the user's default?

@iByteABit256
Copy link
Contributor Author

On Reddit, you can set the sorting order for comments on a per post basis. So sometimes the comments inside a megathread would be set to sorted by new by default. So I guess the post should be able to override the user's default?

This sounds good and would solve my use case, maybe it should be opened as a separate issue alongside this though

@dessalines
Copy link
Member

This should also have a site-wide setting, in addition to the user one.

@dessalines dessalines mentioned this issue Feb 23, 2024
Merged
dessalines added a commit that referenced this issue Feb 24, 2024
@dessalines
Adding a default_comment_sort_type column for local_site and local_user.
be89c12 
- Renamed SortType to PostSortType in the DB and code.
- Renamed references to default_sort_type to default_post_sort_type.
- Fixes #4128
@dessalines dessalines linked a pull request Feb 24, 2024 that will close this issue
Draft
@sunaurus sunaurus mentioned this issue Feb 24, 2024
Closed
4 tasks
@dessalines dessalines mentioned this issue May 4, 2024
Closed
4 tasks
@dessalines
Copy link
Member

For this, we should either utilize the user's default_post_sort (with the post -> comment sort mapping), or add a default_comment_sort field. I'd probably prefer the first one, because that's already in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: sorting enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a default_comment_sort_type column for local_site and local_user. LemmyNet/lemmy
4 participants
@dessalines @Nutomic @Die4Ever @iByteABit256