Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Tiling Assistant emit an (optional!) warning when it can't fully resize/fit a window #314

Open
ahydronous opened this issue Dec 8, 2023 · 5 comments
Labels
enhancement Improve this extensions

Comments

@ahydronous
Copy link

Briefly describe how the feature should work
Tiling Assistant should emit some kind of warning when it tries to tile a window (mostly happens with layouts) to smaller than the minimum window size.

Explain why this feature should be added
For example, currently Discord won't allow to be tiled into a vertical-3-split because that would exceed its minimum window width. But Tiling Assistant will happily put Discord on the rightside edge of the screen and let it tile outside of the screen margins.
This is not a bad thing per sé, but Tiling Assistant should be aware of it and optionally notify the user.

@ahydronous ahydronous added the enhancement Improve this extensions label Dec 8, 2023
@Leleat
Copy link
Owner

Leleat commented Dec 8, 2023

That would be nice, but I am not aware of a way to query a window's minimum size requirement.

@ahydronous
Copy link
Author

You wouldn't need to, you could compare the requested tile (say 50/50 horizontal split or 33/33/33) to the actual window size after tile, and if they don't match up (with % leeway of course), you emit the warning.

@Leleat
Copy link
Owner

Leleat commented Dec 8, 2023

hmm... I'm not sure what the point of a post-attempt warning would be since you should be able to visibly see whether a tiling attempt was successful or not. Do you expect the unsuccessfully tiled window to be automatically untiled after a 'failed attempt' or why do you want a warning?

@ahydronous
Copy link
Author

ahydronous commented Dec 8, 2023

Now that I think more about it, I guess the "real" issue is not that the tiling fail is sometimes easy to miss, but that on right-side tile fail, Tiling Assistant chooses to off-screen a portion of a minimum size window, instead of keeping all of it on-screen but putting part of the window under the window that is to the left.

@kernelb00t
Copy link

Usually, how windows are setting their minimum size? Is it framework-related (like GTK/Electron for example) or by checking the width/height and forcing it when the value changes?
An upstream feature request can be possibly posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve this extensions
Projects
None yet
Development

No branches or pull requests

3 participants