Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: XMR private viewkey export by default #27

Open
dnaleor opened this issue Nov 26, 2018 · 8 comments
Open

Suggestion: XMR private viewkey export by default #27

dnaleor opened this issue Nov 26, 2018 · 8 comments

Comments

@dnaleor
Copy link

dnaleor commented Nov 26, 2018

To enhance the UX , I propose the following:

When the first time the Ledger asks to export the viewkey, the ledger could instead ask:

"Export viewkey by default?"

YES => The viewkey will always be exported, no need to push the button each time. There should be a flag in the Monero app to turn the default exporting off.
NO => the ledger won't ask this question again, but it'll ask the following:

"Export viewkey during this session?"

YES => The viewkey will be exported by default until the ledger is disconnected.
NO => the ledger could ask the following:

"One time viewkey export?"

YES => normal behavior, like it's functioning now.
NO => The ledger will ask this (one time) question:

"Never export viewkey?"

YES => the ledger won't ask to export the viewkey, unless this flag is reversed in a new setting.
NO => nothing changes


During normal usage of the ledger:

if default_export is on => export private viewkey by default
if default_export is off & never_export is off => always ask for session exporting. If answered by no, ask for one time export.
if deault_export is off & never_export is on => never ask for exporting the viewkey

@cslashm
Copy link
Contributor

cslashm commented Jan 23, 2019

I understand the need. I suggest a new entry in setting to set the behavior.

@mmbyday
Copy link

mmbyday commented Feb 15, 2019

+1 This is extra friction and often confusing for the beginner/average monero user, especially the double press required. If possible, should be single press to export view key.

@cslashm
Copy link
Contributor

cslashm commented Feb 18, 2019

The double press is a sideeffect of client code at creation. I will try to fix it for 0.14 if not too buzy on other stuff

@snaggen
Copy link

snaggen commented Jun 27, 2019

Having a setting would improve usability a lot... I tend to forget that I need to export the viewkey, so I just plugin my ledger and open the wallet and then it looks like nothing works.... until I 30 seconds later looks around trying to figure out what is wrong and sees the text on the Ledger. This happens to me more often than it should... so having a default behaviour in a setting would be nice.

@cslashm cslashm added this to the 1.4.0 milestone Jun 27, 2019
@cslashm
Copy link
Contributor

cslashm commented Jun 27, 2019

planned in 1.4.0

@grydz grydz removed this from the 1.4.0 milestone Jun 10, 2020
@Mansarde
Copy link

Mansarde commented Aug 6, 2020

@dnaleor
What is the difference between session and one-time export?

I understand the session export like this:

  • I connect the Ledger to my PC and allow session export.
  • I then open and close the Monero GUI multiple times without being asked again by the Ledger, until I re-connect the Ledger.

Would the one-time export work like this?

  • I connect the Ledger to my PC and allow one-time export.
  • Every time (within the same Ledger session) I re-open the Monero GUI the Ledger asks me to export again?

@dnaleor
Copy link
Author

dnaleor commented Aug 6, 2020

@Mansarde yeah something like that. Although you may simplify and just only use "session export" or only the "one time export". The most important change would be a flag to export by default

@skorokithakis
Copy link

Agreed about the necessity of this feature. I'd go one further and have wallets optionally store the view key on the device, and thus not require the Ledger to be connected unless it's needed for sending or (more rarely) for getting more subaddresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants