Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L.Browser.touch value is true on chrome windows 10 x64 bit #7275

Closed
msschl opened this issue Sep 14, 2020 · 3 comments
Closed

L.Browser.touch value is true on chrome windows 10 x64 bit #7275

msschl opened this issue Sep 14, 2020 · 3 comments
Labels
bug compatibility Cross-browser/device/environment compatibility

Comments

@msschl
Copy link

msschl commented Sep 14, 2020

Up to leaflet v1.6.0 L.Browser.touch returned false on chrome. After the change in PR #7010 in leaflet v1.7.1 this returns true, which messes up some styles for leaflet plugins e.g. https://github.com/pelias/leaflet-plugin/

Is this behavior intended?

Environment

  • Leaflet version: v1.7.1
  • Browser (with version):
  • OS/Platform (with version):
Google Chrome | 85.0.4183.102 (Official Build) (64-bit) (cohort: Stable)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1082)
@IvanSanchez IvanSanchez added bug compatibility Cross-browser/device/environment compatibility labels Sep 14, 2020
@IvanSanchez
Copy link
Member

Paging @johnd0e

@johnd0e
Copy link
Collaborator

johnd0e commented Sep 14, 2020

Nothing wrong is here.

See docs:

// @property touch: Boolean
// `true` for all browsers supporting [touch events](https://developer.mozilla.org/docs/Web/API/Touch_events).
// This does not necessarily mean that the browser is running in a computer with
// a touchscreen, it only means that the browser is capable of understanding
// touch events.

@johnd0e
Copy link
Collaborator

johnd0e commented Sep 14, 2020

Closed as duplicate of #5266

For more background see (for example) nrenner/brouter-web#69

@johnd0e johnd0e closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug compatibility Cross-browser/device/environment compatibility
Projects
None yet
Development

No branches or pull requests

3 participants