Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel saves the Changes #488

Closed
maxmopp opened this issue Jul 6, 2016 · 3 comments
Closed

Cancel saves the Changes #488

maxmopp opened this issue Jul 6, 2016 · 3 comments
Labels

Comments

@maxmopp
Copy link

maxmopp commented Jul 6, 2016

expected: Cancel discards changes, Save saves changes
only works for new note, editing an old note: Cancel saves changes

@claell
Copy link

claell commented Jul 6, 2016

Plus when clicking cancel on a new note the note still will be created.

@wwebfor wwebfor added the bug label Jul 18, 2016
@NWuensche
Copy link
Contributor

I will try to solve this bug. The problem is the auto save feature. It automatically saves after a few seconds, even if I click cancel afterwards. I will try to solve this by auto save in a tmp note, which will be deleted when you click cancel, but not if the program accidentally crashes.

@talklittle
Copy link
Contributor

In addition, it would probably make sense to add a prompt to confirm cancellation when changes are detected.

Currently, thanks to auto save, if I am working on a note for a few hours, then accidentally hit Cancel, I don't lose anything.

If Cancel were to actually discard the changes, then that opens up an easy way to accidentally lose your work.

Ultimately I think the ideal solution would be the addition of Notes History (#125), and then it would make sense to eliminate the distinction between Save and Cancel.

@wwebfor wwebfor closed this as completed in c44cc09 Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants