Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large photo attributes make Baikal drop the connection #3

Open
maichai opened this issue Mar 30, 2020 · 4 comments
Open

large photo attributes make Baikal drop the connection #3

maichai opened this issue Mar 30, 2020 · 4 comments

Comments

@maichai
Copy link

maichai commented Mar 30, 2020

Baikal version: 0.4.6 on Synology DSM 6.2.2

Expected behaviour: if the Baikal server has an empty address book, when connecting the address book (e.g. using macOS app Contacts), and after importing hundreds of contacts, it is expected that all contacts are synced from e.g. macOS Contacts to Baikal server

Current behaviour: in the above scenario only a small fraction of the contacts (something between 80-260) are synced quite fast, then the syncing does not progress any more. The reason was isolated to vCards that contain large picture files. It seems that Baikal is not able to process large PHOTO attributes.

Steps to reproduce:

Install Baikal SKP 
Configure Baikal and set 1 user with 1 address book
Add this user account to e.g. macOS Contacts app
Import a vCard file including several contacts into the account in e.g. macOS Contacts
Upload a large picture file as contact photo into one contact
Select all contacts in e.g. macOS Contacts and export as vCard file
Modify the script https://github.com/ljanyst/carddav-util to do card.prettyPrint() if an upload exception occurs
Use carddav-util to upload the vCard file to Baikal 
See the upload throw an exception due to connection loss and print the vCard with the large picture
@maichai maichai changed the title incomplete CardDAV sync from macOS 10.15 (Catalina) large photo attributes make Baikal drop the connection Apr 2, 2020
@LaurentMarchelli
Copy link
Owner

Hi maichai

Could u please be more specific, how many Mb is a large size.
Most my contacts have a picture and I didn't get any trouble so far.

Thank's in advance,
Best regards,
Laurent Marchelli

@maichai
Copy link
Author

maichai commented Aug 18, 2020

I am sorry, that was monhs ago and I removed a few pictures on which it was choking and since then it works. These were pictures taken in high resolution on the phone. They were several MB, cannot say exactly any more, must have been something in the ballpark of 1-5MB

@LaurentMarchelli
Copy link
Owner

Hi maichai,

Don't need to be sorry, I should have answered sooner, I deeply apologize to not have to.
If it is OK for you, I keep this bug open, however, I'm not sure to have the time to work on it, as I prefer to focus on Baikal's update to fix some CVE.

Best Regard,
Laurent Marchelli

@maichai
Copy link
Author

maichai commented Aug 30, 2020

Sure, its your time and decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants