Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] TinyMCE Editor Becomes Unresponsive After Moving Items in Repeatable Field #5361

Open
h-koba opened this issue Nov 2, 2023 · 4 comments

Comments

@h-koba
Copy link

h-koba commented Nov 2, 2023

Bug report

What I did

I am utilizing the TinyMCE editor within a repeatable field in Laravel Backpack. When I tried to change the order of items within the repeatable field by moving an item, the TinyMCE editor within the moved field became unresponsive.

What I expected to happen

I expected the TinyMCE editor to continue functioning normally, allowing text editing even after moving items within the repeatable field.

What happened

After moving an item within the repeatable field, the TinyMCE editor in the moved field became unresponsive and I was unable to edit text within it.

Is it a bug in the latest version of Backpack?

After I run composer update backpack/pro the bug... is it still there?

Yes, the bug is still present after updating.

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

  • Laravel Version: 10.29.0
  • Backpack Version: backpack/crud: 6.2.4, backpack/pro: 2.0.18
  • PHP Version: 8.1
  • Database Type & Version: MySQL 8.0.30
@h-koba h-koba added the triage label Nov 2, 2023
Copy link

welcome bot commented Nov 2, 2023

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

  • Bug Reports, Feature Requests - Github Issues (here);
  • Quick help (How do I do X) - Gitter Chatroom;
  • Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;
  • Showing off something you've made, asking for opinion on Backpack/Laravel matters - Reddit;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

--
Justin Case
The Backpack Robot

@dimer47
Copy link
Contributor

dimer47 commented Nov 2, 2023

I noticed the same problem on my side using TinyMCE in repeatable fields and changing the order.

I think that the instance of the TinyMCE object is based on a reference to the DOM which is lost following the change of order in the repeatable. I didn't really investigate the problem because I quickly changed editors to summernote.

@phpfour
Copy link
Member

phpfour commented Nov 6, 2023

Hey @h-koba,

Thanks for reporting the issue. I can confirm that it's reproducible and thus we will add this to our backlog to be worked on in an upcoming release.

If you are able to come up with a PR, we'd be happy to review & merge, too.

Cheers

@h-koba
Copy link
Author

h-koba commented Nov 6, 2023

Thank you, @phpfour. I'm looking forward to the fix in the upcoming release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants