./xi_map crash (linux, raspberry pi 4)

[Merire]

Hello,

I followed the Quick-Start-Guide, I can login, create a character but can't select the character because xi_map crashes.
I compiled several times, tried to reset the database several times, still the same error :

[04/23/24 14:52:18:312][map][info] Loading NPC scripts (LoadNPCList:353)
terminate called after throwing an instance of 'std::filesystem::__cxx11::filesystem_error'
what(): filesystem error: status: Invalid or incomplete multibyte or wide character [./scripts/zones/Abyssea-Tahrongi/npcs/▒>.lua]
Crash detected, generating traceback (this may take a while)
luautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Bottomless_Box.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Peshi_Yohnts.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Zahsa_Syalmhaia.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Ada.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Ohbiru-Dohbiru.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Kenapa-Keppa.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Diegai.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Mhabi_Molkot.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Erpolant.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Fuepepe.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Furakku-Norakku.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Baha_Mannohl.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Phuz_Mannohl.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Rhy_Epocan.lualuautils::CacheLuaObjectFromFile: Tried to load file but it does not exist: ./scripts/zones/Abyssea-Tahrongi/npcs/Baladanzo.luaStack trace (most recent call last):
#9 Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0x7fb9985de7, in std::filesystem::status(std::filesystem::__cxx11::path const&)
#8 Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0x7fb98c2703, in __cxa_throw
#7 Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0x7fb98c241f, in std::terminate()
#6 Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0x7fb98c23bb, in std::rethrow_exception(std::__exception_ptr::exception_ptr)
#5 Object "/lib/aarch64-linux-gnu/libstdc++.so.6", at 0x7fb98c49c7, in __gnu_cxx::__verbose_terminate_handler()
#4 Object "/lib/aarch64-linux-gnu/libc.so.6", at 0x7fb95b74bb, in abort
Source "./stdlib/./stdlib/abort.c", line 79, in __GI_abort [0x7fb95b74bb]
#3 Object "/lib/aarch64-linux-gnu/libc.so.6", at 0x7fb95ca76b, in gsignal
Source "./signal/../sysdeps/posix/raise.c", line 26, in __GI_raise [0x7fb95ca76b]
#2 Object "/lib/aarch64-linux-gnu/libc.so.6", at 0x7fb9610a10, in __pthread_kill_implementation
Source "./nptl/./nptl/pthread_kill.c", line 44, in __pthread_kill_implementation [0x7fb9610a10]
#1 Object "linux-vdso.so.1", at 0x7fb9e097bb, in
#0 Object "/mypath/landsandboat/server/xi_map", at 0x55928210ef, in dumpBacktrace(int)
Source "/mypath/landsandboat/server/src/common/debug_linux.cpp", line 28, in dumpBacktrace(int) [0x55928210ef]
25: backward::StackTrace trace;
26: backward::Printer printer;
27:
> 28: trace.load_here(10);
29:
30: printer.object = true;
31: printer.color_mode = backward::ColorMode::always;
Quit

I'm guessing maybe an encoding problem since there is a weird character there : ./scripts/zones/Abyssea-Tahrongi/npcs/▒>.lua but I don't know really.

I saw other also have crashing on xi_maps but on windows so I'm opening a new topic. I know several languages but not c++ so I can't really locate the issue, I checked the encoding of zoneutils.cpp encoding and LF seems ok to me...

Any advice ?

[WinterSolstice8]

Try this patch:

index 086e117c94..d79574a777 100644
--- a/src/map/lua/luautils.cpp
+++ b/src/map/lua/luautils.cpp
@@ -808,6 +808,20 @@ namespace luautils
         std::string filename;
         if (PEntity->objtype == TYPE_NPC)
         {
+            auto isNamePrintable = [PEntity](std::string name)
+            {
+                if ( std::all_of( name.begin(), name.end(), []( char c ) { return !std::isgraph( c ); } ) )
+                {
+                    return false;
+                }
+                return true;
+            };
+
+            if (!isNamePrintable(PEntity->getName()))
+            {
+                return;
+            }
+
             std::string zone_name = PEntity->loc.zone->getName();
             std::string npc_name  = PEntity->getName();
             filename              = fmt::format("./scripts/zones/{}/npcs/{}.lua", zone_name, npc_name);

[WinterSolstice8]

Explanation: some NPC names are non-printable because of SE related jank. They will never have npc scripts so this will skip trying to load them.

[WinterSolstice8]

(this code doesn't work, see #5501 for a real potential patch)

[Merire]

It almost works : I had to replace all_of with any_of (since there were graph AND not graph characters in the name) and now it doesn't crash.
I have to test ingame, however.

[Merire]

well, still got 3001 error but at least server doesn't crash, maybe another issue.

edit - solved the other issue (--hairpin in xiloader) now it works I think. @WinterSolstice8 should I do a pull request or something ? I'm not really sure why my locale settings are problematic, I can give more informations or test more if needed.

[WinterSolstice8]

I'm not really sure why my locale settings are problematic

This happens on windows too, we are (unintentionally) feeding the filesystem bad paths

And sure, if you have a fix for xiloader go ahead

[Merire]

yeah no I was talking about the luautils fix, the one you made but I modified :

auto isNamePrintable = [PEntity](std::string name)
{
if ( std::any_of( name.begin(), name.end(), []( char c ) { return !std::isgraph( c ); } ) )
{
return false;
}
return true;
};
if (!isNamePrintable(PEntity->getName()))
{
return;
}

I changed std::all_of to std::any_of and now the fix works. Just saying since you said in #5496 (reply in thread) that it didn't work.

Not sure of wich route (this or the ANSI route in #5501 ) is the best.