Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring me a Feature! #61

Open
r-brown opened this issue Oct 5, 2019 · 10 comments
Open

Bring me a Feature! #61

r-brown opened this issue Oct 5, 2019 · 10 comments
Assignees
Labels
enhancement hacktoberfest Hacktoberfest ready issue

Comments

@r-brown
Copy link
Member

r-brown commented Oct 5, 2019

Hacktoberfest feature challenge!

Suggest and Pull a new feature, which is adding great value for the Laravel Boilerplate users.


@ALL contributors
In the case of unique->tested->accepted feature we'll be happy to include your GitHub handle in the list of contributors on the main boilerplate page (README.md) - https://github.com/Labs64/laravel-boilerplate#contributors-and-supporters

@r-brown r-brown added enhancement hacktoberfest Hacktoberfest ready issue labels Oct 5, 2019
@einnar82
Copy link

einnar82 commented Oct 5, 2019

Adding CORS feature and my package :)

@einnar82
Copy link

einnar82 commented Oct 5, 2019

#62

@veerajongit
Copy link

What about a package that does the testing automatically every time the code or the test changes?

@r-brown
Copy link
Member Author

r-brown commented Oct 6, 2019

@veerajongit Sounds great! Would it be possible also to enable these tests for TravisCI?

@veerajongit
Copy link

veerajongit commented Oct 7, 2019

#65

@nowendwell
Copy link
Contributor

nowendwell commented Oct 31, 2019

Would you guys want the ability to archive users similar to the idea of SoftDeletes?

@r-brown
Copy link
Member Author

r-brown commented Nov 1, 2019

Hi @nowendwell - this might a good improvement here. Thanks!
Any option to enable also complete GDPR compliant deletion and data provisioning?! ;)

@nowendwell
Copy link
Contributor

I think I can spin something up. Thinking a Trait (Forgetable or GDPRPolicy or something) that would call a variable on the model to find the relationships. The trait would have download() and permanentDelete() methods that do the respective tasks.

I'm thinking

protected $gdpr_relations = [
    'providers',
    'protectionValidation',
    'protectionShopTokens'
];

That way you could call

// Route
Route::delete('/user/{user}', 'UserController@permanentDelete');

// User Controller
public function permanentDelete(User $user)
{
    $user->permanentDelete();

    return back();
}

// GDPRPolicy Trait
public function permanentDelete()
{
    foreach($this->gdpr_relations as $relation) {
        $relation->forceDelete();
    }

    return true;
}

As for the data provisioning (downloading data right?) do you want to pull in an Excel library and make it fancy or just stick with an fputcsv kinda thing?

I'm thinking if we're just going the fputcsv route something like this

users
id name pass
1 Ben $@sdisdfkj
social_accounts
id user_id provider provider_id token
1 1 fb 24351 $NWED(NCAIU3

Let me know your thoughts.

@r-brown
Copy link
Member Author

r-brown commented Nov 1, 2019

Hi @nowendwell the suggestion looks really good - let's do it.
Also the export as CVS is ways better - it should be simple.

@r-brown
Copy link
Member Author

r-brown commented Jan 31, 2020

New feature request added - #73 Add Guided Tour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest Hacktoberfest ready issue
Development

No branches or pull requests

5 participants