Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG_PRINT should replace ASN_PRINT, printf, and std::iostream #209

Open
raub opened this issue Nov 18, 2023 · 4 comments
Open

LOG_PRINT should replace ASN_PRINT, printf, and std::iostream #209

raub opened this issue Nov 18, 2023 · 4 comments

Comments

@raub
Copy link
Contributor

raub commented Nov 18, 2023

This is probably from debugging:
https://github.com/LabSound/LabSound/blob/v1.2.0/src/core/AudioNode.cpp#L20

A similar log is currently in main:
https://github.com/LabSound/LabSound/blob/main/src/core/AudioNode.cpp#L19

Also, why not use LOG_TRACE or some of those?

@meshula
Copy link
Member

meshula commented Nov 18, 2023

It's historic. ASN_PRINT is very old, and should have been moved when LOG_TRACE was introduced. I hadn't thought about that point.

@raub
Copy link
Contributor Author

raub commented Nov 19, 2023

Well that's currently named LOG_PLAYBACK_STATE_TRANSITION. Switching to LOG_TRACE makes sense.

@raub
Copy link
Contributor Author

raub commented Nov 20, 2023

Also when using loadHrtfDatabase, I get a ton of logs from https://github.com/LabSound/LabSound/blob/main/src/extended/AudioFileReader.cpp#L85 - because printf is used directly.

@meshula meshula changed the title Version 1.2.0 ASN_PRINT is visible LOG_PRINT should replace ASN_PRINT, printf, and std::iostream Nov 20, 2023
@meshula
Copy link
Member

meshula commented Nov 20, 2023

You've found enough inconsistencies to make this a specific task to clean up all logging and tracing ~ I renamed the issue to be more general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants