Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Windows 10 #389

Closed
YT-Advanced opened this issue Feb 14, 2023 · 12 comments
Closed

[Feature Request] Support Windows 10 #389

YT-Advanced opened this issue Feb 14, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@YT-Advanced
Copy link

Is your feature request related to a problem?/你的请求是否与某个问题相关?

In github, we have a patch to enable WSA run on Windows 10. Here is the reporistory: https://github.com/cinit/WSAPatch

Describe the solution you'd like/描述你想要的解决方案

On install file, add some code to check the Windows version, then if the Windows version is 10, the file will auto copy and paste modifided file to WSA and run it

Additional context/其他信息

No response

@YT-Advanced YT-Advanced added the enhancement New feature or request label Feb 14, 2023
@MustardChef
Copy link

MustardChef commented Feb 14, 2023

This would be a great option. But, from what I have seen so far, running WSA on Windows 10 is not without its problems. It either works great or it does not. I think its really up to the devs, whether or not it is worth adding.

@YT-Advanced
Copy link
Author

YT-Advanced commented Feb 17, 2023

@MustardChef I have create the ones have support both Windows 10 x64 and Windows 11 x64. Can you check for me before I send a pull request ?
Download link: CLICK HERE

@MustardChef
Copy link

@MustardChef I have create the ones have support both Windows 10 x64 and Windows 11 x64. Can you check for me before I send a pull request ? Download link: CLICK HERE

Seems to be working

@YT-Advanced
Copy link
Author

@MustardChef I have create the ones have support both Windows 10 x64 and Windows 11 x64. Can you check for me before I send a pull request ? Download link: CLICK HERE

Seems to be working

Thanks but now I have some problem on Windows 11 and I'm fixing it :D

@MustardChef
Copy link

MustardChef commented Feb 18, 2023

@YT-Advanced Also I would recommend having the script download the latest WSAPatch dlls from Github rather than having them pre-downloaded in the "installer" folder and updated manually every new release/ prerelease

@YT-Advanced
Copy link
Author

YT-Advanced commented Feb 19, 2023

@MustardChef Check my Github, all are done now.
Github Link: https://github.com/YT-Advanced/WSA-Script

@YT-Advanced
Copy link
Author

YT-Advanced commented Feb 22, 2023

@MustardChef I think you can add to your WSABuild repos a Custom Build option that can be help user to build they own :D

@MustardChef
Copy link

MustardChef commented Feb 22, 2023

@MustardChef I think you can add to your WSABuild repos a Custom Build option that can be help user to build they own :D

Yes, that seems like a great idea. I will experiment with the Github Actions Workflow and add a link and instructions to your repo. However I would be cautious as I don't want the repo to be disabled.

@YT-Advanced
Copy link
Author

@MustardChef I think you can add to your WSABuild repos a Custom Build option that can be help user to build they own :D

Vâng, đó có vẻ là một ý tưởng tuyệt vời. Tôi sẽ thử nghiệm với Github Actions Workflow và thêm một liên kết và hướng dẫn vào repo của bạn. Tuy nhiên, tôi sẽ thận trọng vì tôi không muốn repo bị vô hiệu hóa.

yes, so I think let user to use compiled package in release is better

@Howard20181
Copy link
Member

Howard20181 commented Feb 23, 2023

yes, so I think let user to use compiled package in release is better

#4 (comment)

In my opinion, don't provide Actions-based builds if you don't want the repository to be disabled. Even if you export to Releases it will still be disabled.

@YT-Advanced
Copy link
Author

@Howard20181 I known that so I will move my repo to Gitlab in the future, but not now because I am so busy :(

@djfaizp

This comment was marked as off-topic.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants