Moved RingBuffer to plugins/MultitapEcho #7213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See my comment on #7137 - I don't think there's any need to get rid of this class. I wouldn't even move it for now - it likely has utility in the core for something like latency compensation. |
|
Silly me doing work which no one asked for. |
|
I am looking to revive this PR. I don't expect to get merged but see some benefits in scoping the file down. |
|
I think i now understand about what's going on with the build fail. Looks like |
|
I'm biting more than i can chew. again. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7137
per #7137 (comment) by @michaelgregorius , this
RingBufferclass is only being used by the MultitapEcho plugin and is needlessly referenced in the core. So I moved it to the MultitapEcho plugin folder.Todo : The effect should be changed to useLocklessRingBufferinstead but that can be done in a follow up PR (I'm scared of messing up something and breaking the plugin)Both implementations have seperate purposes so I'll just scope down for now.