Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives in HiOp functionality tests #594

Open
pelesh opened this issue Feb 9, 2023 · 0 comments
Open

False positives in HiOp functionality tests #594

pelesh opened this issue Feb 9, 2023 · 0 comments

Comments

@pelesh
Copy link
Collaborator

pelesh commented Feb 9, 2023

It seems that HiOp functionality tests can give false positive when the result is nan of inf due to C++ comparison rules for those cases. See, for example, #585. Perhaps we could check for nans and infs first and declare test failed if this is the result?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pelesh