Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check to defend against bad linker flags? #610

Open
cyrush opened this issue Jan 6, 2023 · 0 comments
Open

check to defend against bad linker flags? #610

cyrush opened this issue Jan 6, 2023 · 0 comments

Comments

@cyrush
Copy link
Member

cyrush commented Jan 6, 2023

observation:

If you add CMAKE_EXE_LINKER_FLAGS and have a typo (e.g: misspell a lib name), this will cause failures downstream when you get to BLT-builtin TPL support. In my case, finding MPI failed and there was no output that would signal it is related the lib flags, just "I can't find MPI!"

Since these flags are used everywhere, a compile check that uses these flags early could detect an issue and allow us to provide a better error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant